Skip to content

test: avoid infamy0 race in CI by using random container names#1482

Merged
troglobit merged 1 commit intomainfrom
random-infamy-id-in-ci
Apr 28, 2026
Merged

test: avoid infamy0 race in CI by using random container names#1482
troglobit merged 1 commit intomainfrom
random-infamy-id-in-ci

Conversation

@rical
Copy link
Copy Markdown
Contributor

@rical rical commented Apr 28, 2026

Description

Prior to this PR, two CI jobs that starts at the same time, could both get ID 0 and grab infamy0. This resulted in one crashing. This usually happened when there was much to test, typically during a release....

In this PR we use the CI variable that GitHub Actions sets. We treat it like -r so parallel jobs don't all try to claim "infamy0" and clobber each other.

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

GitHub Actions sets $CI=true; treat it like -r so parallel jobs
don't all try to claim "infamy0" and clobber each other.
Copy link
Copy Markdown
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean fix, I like it!

@troglobit troglobit linked an issue Apr 28, 2026 that may be closed by this pull request
@troglobit troglobit merged commit 2788eb6 into main Apr 28, 2026
9 checks passed
@troglobit troglobit deleted the random-infamy-id-in-ci branch April 28, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When start tests in a workflow, use random infamy id

2 participants